Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt

Issue 1274403002: GC plugin: consider references equal to raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Propagate reference type into error/warning messages Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt
diff --git a/tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt b/tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt
index 985ea2745c00e4f4dff703237aaf457dc2dadba0..463e9aebb366c2ed981998414d775b20b38b5344 100644
--- a/tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt
+++ b/tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt
@@ -2,13 +2,19 @@ In file included from raw_ptr_to_gc_managed_class.cpp:5:
./raw_ptr_to_gc_managed_class.h:14:1: warning: [blink-gc] Class 'PartObject' contains invalid fields.
class PartObject {
^
-./raw_ptr_to_gc_managed_class.h:17:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC managed class declared here:
+./raw_ptr_to_gc_managed_class.h:19:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC managed class declared here:
RawPtr<HeapObject> m_obj;
^
-./raw_ptr_to_gc_managed_class.h:20:1: warning: [blink-gc] Class 'HeapObject' contains invalid fields.
+./raw_ptr_to_gc_managed_class.h:20:5: note: [blink-gc] Raw pointer field 'm_rawObj' to a GC managed class declared here:
+ HeapObject* m_rawObj;
+ ^
+./raw_ptr_to_gc_managed_class.h:21:5: note: [blink-gc] Reference pointer field 'm_refObj' to a GC managed class declared here:
+ HeapObject& m_refObj;
+ ^
+./raw_ptr_to_gc_managed_class.h:24:1: warning: [blink-gc] Class 'HeapObject' contains invalid fields.
class HeapObject : public GarbageCollected<HeapObject> {
^
-./raw_ptr_to_gc_managed_class.h:25:5: note: [blink-gc] Raw pointer field 'm_objs' to a GC managed class declared here:
+./raw_ptr_to_gc_managed_class.h:29:5: note: [blink-gc] Raw pointer field 'm_objs' to a GC managed class declared here:
HeapVector<HeapObject*> m_objs;
^
2 warnings generated.
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698