Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt

Issue 1274403002: GC plugin: consider references equal to raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Propagate reference type into error/warning messages Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from raw_ptr_to_gc_managed_class.cpp:5: 1 In file included from raw_ptr_to_gc_managed_class.cpp:5:
2 ./raw_ptr_to_gc_managed_class.h:14:1: warning: [blink-gc] Class 'PartObject' con tains invalid fields. 2 ./raw_ptr_to_gc_managed_class.h:14:1: warning: [blink-gc] Class 'PartObject' con tains invalid fields.
3 class PartObject { 3 class PartObject {
4 ^ 4 ^
5 ./raw_ptr_to_gc_managed_class.h:17:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC managed class declared here: 5 ./raw_ptr_to_gc_managed_class.h:19:5: note: [blink-gc] Raw pointer field 'm_obj' to a GC managed class declared here:
6 RawPtr<HeapObject> m_obj; 6 RawPtr<HeapObject> m_obj;
7 ^ 7 ^
8 ./raw_ptr_to_gc_managed_class.h:20:1: warning: [blink-gc] Class 'HeapObject' con tains invalid fields. 8 ./raw_ptr_to_gc_managed_class.h:20:5: note: [blink-gc] Raw pointer field 'm_rawO bj' to a GC managed class declared here:
9 HeapObject* m_rawObj;
10 ^
11 ./raw_ptr_to_gc_managed_class.h:21:5: note: [blink-gc] Reference pointer field ' m_refObj' to a GC managed class declared here:
12 HeapObject& m_refObj;
13 ^
14 ./raw_ptr_to_gc_managed_class.h:24:1: warning: [blink-gc] Class 'HeapObject' con tains invalid fields.
9 class HeapObject : public GarbageCollected<HeapObject> { 15 class HeapObject : public GarbageCollected<HeapObject> {
10 ^ 16 ^
11 ./raw_ptr_to_gc_managed_class.h:25:5: note: [blink-gc] Raw pointer field 'm_objs ' to a GC managed class declared here: 17 ./raw_ptr_to_gc_managed_class.h:29:5: note: [blink-gc] Raw pointer field 'm_objs ' to a GC managed class declared here:
12 HeapVector<HeapObject*> m_objs; 18 HeapVector<HeapObject*> m_objs;
13 ^ 19 ^
14 2 warnings generated. 20 2 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698