[Android] Limit context menu title to 1024 characters

[Android] Limit context menu title to 1024 characters

Recenly the context menu title was made scrollable. However, there are
cases where unreasonably long strings can be fed to the title, leading
to sluggish longpress response and even memory allocation issues.
Provide a reasonable upper bound of 1024 characters for the title.

BUG=516836
Committed: https://crrev.com/ec35964bd1895111f40242890270e5f8034b376c
Cr-Commit-Position: refs/heads/master@{#343237}

[jdduke (slow), 2015-08-11 21:23:26]

jdduke@chromium.org changed reviewers:
+ dtrainor@chromium.org

[jdduke (slow), 2015-08-11 21:23:26]

dtrainor@: PTAL, thanks.

[David Trainor- moved to gerrit, 2015-08-12 22:13:00]

https://chromiumcodereview.appspot.com/1274373005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
(right):

https://chromiumcodereview.appspot.com/1274373005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java:39:
sb.append(ELLIPSIS);
You should probably use TextUtils.ellipsize() as that handles a lot of cases and
uses the correct ellipse unicode character.

[jdduke (slow), 2015-08-12 22:30:26]

https://chromiumcodereview.appspot.com/1274373005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
(right):

https://chromiumcodereview.appspot.com/1274373005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java:39:
sb.append(ELLIPSIS);
On 2015/08/12 22:13:00, David Trainor wrote:
> You should probably use TextUtils.ellipsize() as that handles a lot of cases
and
> uses the correct ellipse unicode character.

I looked at that, but it seems to only occomadate truncation to a single line.
We're OK having multiple lines here, we just don't want too many. I guess I
could provide some dummy width input? I think we'd need to change it to to a
TextView to get a proper TextPaint handle?

I can also just use the right unicode character here, we don't need to be exact
we just want to make sure we're not dumping megabytes of text into the View.

[David Trainor- moved to gerrit, 2015-08-12 23:35:02]

https://chromiumcodereview.appspot.com/1274373005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
(right):

https://chromiumcodereview.appspot.com/1274373005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java:39:
sb.append(ELLIPSIS);
On 2015/08/12 22:30:25, jdduke wrote:
> On 2015/08/12 22:13:00, David Trainor wrote:
> > You should probably use TextUtils.ellipsize() as that handles a lot of cases
> and
> > uses the correct ellipse unicode character.
> 
> I looked at that, but it seems to only occomadate truncation to a single line.
> We're OK having multiple lines here, we just don't want too many. I guess I
> could provide some dummy width input? I think we'd need to change it to to a
> TextView to get a proper TextPaint handle?
> 
> I can also just use the right unicode character here, we don't need to be
exact
> we just want to make sure we're not dumping megabytes of text into the View.

Ah good point.  Yeah let's just use the unicode character and check LTR/RTL.

[jdduke (slow), 2015-08-13 17:16:13]

Switched to unicode.

https://codereview.chromium.org/1274373005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
(right):

https://codereview.chromium.org/1274373005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java:39:
sb.append(ELLIPSIS);
On 2015/08/12 23:35:02, David Trainor wrote:
> On 2015/08/12 22:30:25, jdduke wrote:
> > On 2015/08/12 22:13:00, David Trainor wrote:
> > > You should probably use TextUtils.ellipsize() as that handles a lot of
cases
> > and
> > > uses the correct ellipse unicode character.
> > 
> > I looked at that, but it seems to only occomadate truncation to a single
line.
> > We're OK having multiple lines here, we just don't want too many. I guess I
> > could provide some dummy width input? I think we'd need to change it to to a
> > TextView to get a proper TextPaint handle?
> > 
> > I can also just use the right unicode character here, we don't need to be
> exact
> > we just want to make sure we're not dumping megabytes of text into the View.
> 
> Ah good point.  Yeah let's just use the unicode character and check LTR/RTL.

Shouldn't the TextView do the LTR/RTL layout properly? I don't think RTL strings
are actually laid out differently in memory, maybe I'm missing something.

[David Trainor- moved to gerrit, 2015-08-13 17:44:40]

good point!  lgtm.

[jdduke (slow), 2015-08-13 17:51:03]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2015-08-13 17:51:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274373005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274373005/20001

[commit-bot: I haz the power, 2015-08-13 18:26:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-13 18:27:43]

Patchset 2 (id:??) landed as
https://crrev.com/ec35964bd1895111f40242890270e5f8034b376c
Cr-Commit-Position: refs/heads/master@{#343237}