Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: tests/language/partial_min_test.dart

Issue 12743005: Revert "Remove Expect from core library." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload (first upload failed). Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/language/parse_types_test.dart ('k') | tests/language/patch_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "package:expect/expect.dart";
6
7 // This test triggered an NPE in dart2js. 5 // This test triggered an NPE in dart2js.
8 // The bug needed: 6 // The bug needed:
9 // - double usage of the same variable in one expression ("b != b"). 7 // - double usage of the same variable in one expression ("b != b").
10 // - replacement of "b" with "typechecked b". 8 // - replacement of "b" with "typechecked b".
11 // - ... 9 // - ...
12 // The example below is minimal (as far as I was able to do). 10 // The example below is minimal (as far as I was able to do).
13 11
14 num foo(num a, num b) { 12 num foo(num a, num b) {
15 if (a > b) return b; 13 if (a > b) return b;
16 if (b is double) { 14 if (b is double) {
17 if (true) { 15 if (true) {
18 if (true) { 16 if (true) {
19 return (a + b) * a * b; 17 return (a + b) * a * b;
20 } 18 }
21 } 19 }
22 // Check for NaN and b == -0.0. 20 // Check for NaN and b == -0.0.
23 if (a == 0 && b == 0 || b != b) return b; 21 if (a == 0 && b == 0 || b != b) return b;
24 } 22 }
25 } 23 }
26 24
27 main() { 25 main() {
28 Expect.equals(1, foo(2, 1)); 26 Expect.equals(1, foo(2, 1));
29 } 27 }
OLDNEW
« no previous file with comments | « tests/language/parse_types_test.dart ('k') | tests/language/patch_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698