Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: tests/language/list_double_index_in_loop_test.dart

Issue 12743005: Revert "Remove Expect from core library." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload (first upload failed). Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/language/list_double_index_in_loop2_test.dart ('k') | tests/language/list_is_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Dart test program for testing arrays. 4 // Dart test program for testing arrays.
5 5
6 import "package:expect/expect.dart";
7
8 bar() => true; 6 bar() => true;
9 7
10 // The type propagation in Dart2Js wrongly took the intersection of all incoming 8 // The type propagation in Dart2Js wrongly took the intersection of all incoming
11 // types in a loop-phi. In this case the back-edge brought type 'number' which, 9 // types in a loop-phi. In this case the back-edge brought type 'number' which,
12 // combined with 'integer' (i = 0) was narrowed to 'integer'. As a result no 10 // combined with 'integer' (i = 0) was narrowed to 'integer'. As a result no
13 // check was inserted for the list access. 11 // check was inserted for the list access.
14 foo(a) { 12 foo(a) {
15 var i = 0; 13 var i = 0;
16 while (true) { 14 while (true) {
17 if (i > 1) return a[i]; 15 if (i > 1) return a[i];
18 if (bar()) { 16 if (bar()) {
19 // Adding a double guarantees a double result. Therefore guard by an if. 17 // Adding a double guarantees a double result. Therefore guard by an if.
20 i = i + 1.5; 18 i = i + 1.5;
21 } 19 }
22 } 20 }
23 } 21 }
24 22
25 main() { 23 main() {
26 Expect.throws(() => foo([1, 2])); 24 Expect.throws(() => foo([1, 2]));
27 } 25 }
OLDNEW
« no previous file with comments | « tests/language/list_double_index_in_loop2_test.dart ('k') | tests/language/list_is_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698