Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274263003: Revert of Delete AuthorStyleInfo and move its data into ComputedStyle.RareNonInheritedData. (Closed)

Created:
5 years, 4 months ago by caseq
Modified:
5 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-rendering, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Delete AuthorStyleInfo and move its data into ComputedStyle.RareNonInheritedData. (patchset #20 id:380001 of https://codereview.chromium.org/1251523003/ ) Reason for revert: This breaks button styling in DevTools in a lot of fancy ways. BUG=517567 Original issue's description: > Delete AuthorStyleInfo & move its data into ComputedStyle.RareNonInheritedData. > > This allows caching of styles that may be affected by LayoutThemes as > the data is now available even when cached. > > > BUG=259995 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199708 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200094 TBR=dstockwell@chromium.org,ojan@chromium.org,timloh@chromium.org,meade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=259995 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -63 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 3 chunks +23 lines, -30 lines 0 comments Download
M Source/core/layout/LayoutTheme.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTheme.cpp View 5 chunks +9 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeMac.mm View 3 chunks +4 lines, -3 lines 0 comments Download
A Source/core/style/AuthorStyleInfo.h View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/style/StyleRareNonInheritedData.cpp View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caseq
Created Revert of Delete AuthorStyleInfo and move its data into ComputedStyle.RareNonInheritedData.
5 years, 4 months ago (2015-08-06 18:37:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274263003/1
5 years, 4 months ago (2015-08-06 18:37:49 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 18:38:24 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200114

Powered by Google App Engine
This is Rietveld 408576698