Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1274213004: Fix iOS after https://codereview.chromium.org/1278433002/ (Closed)

Created:
5 years, 4 months ago by blundell
Modified:
5 years, 4 months ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix iOS after https://codereview.chromium.org/1278433002/ Inadvertently removed lines from ios_chrome.gyp due to a bad rebase. Committed: https://crrev.com/51118791a8e312fc66434fe5789f313f2a508cce Cr-Commit-Position: refs/heads/master@{#342361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
blundell
5 years, 4 months ago (2015-08-07 15:33:59 UTC) #2
droger
lgtm
5 years, 4 months ago (2015-08-07 15:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274213004/1
5 years, 4 months ago (2015-08-07 15:43:43 UTC) #5
blundell
Please hit CQ on this if you lgtm it.
5 years, 4 months ago (2015-08-07 15:43:44 UTC) #6
droger
On 2015/08/07 15:43:44, blundell wrote: > Please hit CQ on this if you lgtm it. ...
5 years, 4 months ago (2015-08-07 15:44:20 UTC) #7
blundell
On 2015/08/07 15:44:20, droger wrote: > On 2015/08/07 15:43:44, blundell wrote: > > Please hit ...
5 years, 4 months ago (2015-08-07 15:51:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 15:58:05 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 15:58:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51118791a8e312fc66434fe5789f313f2a508cce
Cr-Commit-Position: refs/heads/master@{#342361}

Powered by Google App Engine
This is Rietveld 408576698