Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1274203003: dart2js: Ensure each use site of a name uses a new ast node. (Closed)

Created:
5 years, 4 months ago by herhut
Modified:
5 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Ensure each use site of a name uses a new ast node. R=johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/18c3d2186f3ad2a7154559ab31915ac3403aecb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
M pkg/compiler/lib/src/js_backend/namer.dart View 8 chunks +15 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer_names.dart View 9 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
5 years, 4 months ago (2015-08-10 11:56:25 UTC) #1
Johnni Winther
lgtm
5 years, 4 months ago (2015-08-10 13:29:47 UTC) #2
herhut
5 years, 4 months ago (2015-08-11 08:37:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
18c3d2186f3ad2a7154559ab31915ac3403aecb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698