Instant: Allow empty sets to be added to the cache.

Instant: Allow empty sets to be added to the cache.

BUG=223671
R=shishir@chromium.org,brettw@chromium.org
TEST=See bug.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190516

[sreeram, 2013-03-25 20:53:57]

@shishir for review
@sky for OWNERS

[Shishir, 2013-03-25 20:55:42]

lgtm

[sreeram, 2013-03-25 20:59:03]

@brettw for OWNERS

[brettw, 2013-03-25 22:26:52]

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
File chrome/common/instant_restricted_id_cache.h (right):

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
chrome/common/instant_restricted_id_cache.h:97: return;
I'm wondering about this. If you add too many items, does this actually do what
we want? The current items will still be the old ones. It seems like you would
want the same behavior as you currently have in the "add an empty vector" case.

[sreeram, 2013-03-25 22:29:33]

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
File chrome/common/instant_restricted_id_cache.h (right):

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
chrome/common/instant_restricted_id_cache.h:97: return;
On 2013/03/25 22:26:52, brettw wrote:
> I'm wondering about this. If you add too many items, does this actually do
what
> we want? The current items will still be the old ones. It seems like you would
> want the same behavior as you currently have in the "add an empty vector"
case.

Adding too many items would be an error situation, i.e., not supported. Changing
it to be the same as adding an empty set (which _is_ supported) would give the
wrong impression of stuff working, while in fact silently breaking things. I
don't mind changing the 'if' to a DCHECK(), if you prefer?

[brettw, 2013-03-25 22:34:03]

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
File chrome/common/instant_restricted_id_cache.h (right):

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
chrome/common/instant_restricted_id_cache.h:97: return;
Yeah, I like the dcheck.

[sreeram, 2013-03-25 22:39:26]

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
File chrome/common/instant_restricted_id_cache.h (right):

https://codereview.chromium.org/12742014/diff/1/chrome/common/instant_restric...
chrome/common/instant_restricted_id_cache.h:97: return;
On 2013/03/25 22:34:04, brettw wrote:
> Yeah, I like the dcheck.

Done.

[brettw, 2013-03-25 22:43:03]

lgtm

[sreeram, 2013-03-26 00:15:02]

Committed patchset #2 manually as r190516 (presubmit successful).