chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc - Issue 12742013: Inconsistent use of [x] close panel icon. Code changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc

Issue 12742013: Inconsistent use of [x] close panel icon. Code changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_217094_3

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc

diff --git a/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc b/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc

index 4f6dff9318f83d7cecf5d6d7414827a83e0f690c..5c8b7f2e820131d059da2b1c19d104ce7374476c 100644

--- a/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc

+++ b/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc

@@ -489,7 +489,7 @@ void WebsiteSettingsPopupGtk::SetIdentityInfo(

gtk_label_set_attributes(GTK_LABEL(identity_label), attributes);

pango_attr_list_unref(attributes);

gtk_box_pack_start(GTK_BOX(hbox), identity_label, FALSE, FALSE, 0);

- close_button_.reset(CustomDrawButton::CloseButton(theme_service_));

+ close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_service_));

g_signal_connect(close_button_->widget(), "clicked",

G_CALLBACK(OnCloseButtonClickedThunk), this);

gtk_box_pack_start(GTK_BOX(hbox), close_button_->widget(), FALSE, FALSE, 0);

« no previous file with comments | « chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/ui/views/download/download_shelf_view.cc » ('j') | no next file with comments »