chrome/browser/profiles/profile_io_data.cc - Issue 1274143002: ClientCertStoreChromeOS: support additional non-platform certs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 1274143002: ClientCertStoreChromeOS: support additional non-platform certs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored to suggested pulling of certificates. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/platform_keys/platform_keys_nss.cc ('K') | « chrome/browser/chromeos/platform_keys/platform_keys_nss.cc ('k') | net/ssl/client_cert_store_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_io_data.cc

diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc

index be83c4eef32019ec1e6a14cd727066b09b82963c..c3cf13db043ffa62485eb0e8b7fc3bb7deb7811d 100644

--- a/chrome/browser/profiles/profile_io_data.cc

+++ b/chrome/browser/profiles/profile_io_data.cc

@@ -114,6 +114,7 @@

#endif // defined(OS_ANDROID)

#if defined(OS_CHROMEOS)

+#include "chrome/browser/chromeos/certificate_provider/certificate_provider.h"

#include "chrome/browser/chromeos/fileapi/external_file_protocol_handler.h"

#include "chrome/browser/chromeos/login/startup_utils.h"

#include "chrome/browser/chromeos/net/cert_verify_proc_chromeos.h"

@@ -940,6 +941,7 @@ ProfileIOData::ResourceContext::CreateClientCertStore() {

return io_data_->client_cert_store_factory_.Run();

#if defined(OS_CHROMEOS)

return scoped_ptr<net::ClientCertStore>(new chromeos::ClientCertStoreChromeOS(

+ nullptr, // no additional certs

davidben 2015/08/14 21:49:16 "No additional provider." perhaps?

pneubeck (no reviews) 2015/08/17 12:01:32 Done.

make_scoped_ptr(new chromeos::ClientCertFilterChromeOS(

io_data_->use_system_key_slot(), io_data_->username_hash())),

base::Bind(&CreateCryptoModuleBlockingPasswordDelegate,