Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Side by Side Diff: chrome/browser/chromeos/net/client_cert_store_chromeos.h

Issue 1274143002: ClientCertStoreChromeOS: support additional non-platform certs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Steven's comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_NET_CLIENT_CERT_STORE_CHROMEOS_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_NET_CLIENT_CERT_STORE_CHROMEOS_H_
6 #define CHROME_BROWSER_CHROMEOS_NET_CLIENT_CERT_STORE_CHROMEOS_H_ 6 #define CHROME_BROWSER_CHROMEOS_NET_CLIENT_CERT_STORE_CHROMEOS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector>
9 10
11 #include "base/macros.h"
12 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
14 #include "net/cert/x509_certificate.h"
11 #include "net/ssl/client_cert_store_nss.h" 15 #include "net/ssl/client_cert_store_nss.h"
12 16
13 namespace net {
14 class X509Certificate;
15 }
16
17 namespace chromeos { 17 namespace chromeos {
18 18
19 class ClientCertStoreChromeOS : public net::ClientCertStoreNSS { 19 class CertificateProvider;
20
21 class ClientCertStoreChromeOS : public net::ClientCertStore {
20 public: 22 public:
23 using PasswordDelegateFactory =
24 net::ClientCertStoreNSS::PasswordDelegateFactory;
25
21 class CertFilter { 26 class CertFilter {
22 public: 27 public:
23 virtual ~CertFilter() {} 28 virtual ~CertFilter() {}
24 29
25 // Initializes this filter. Returns true if it finished initialization, 30 // Initializes this filter. Returns true if it finished initialization,
26 // otherwise returns false and calls |callback| once the initialization is 31 // otherwise returns false and calls |callback| once the initialization is
27 // completed. 32 // completed.
28 // Must be called at most once. 33 // Must be called at most once.
29 virtual bool Init(const base::Closure& callback) = 0; 34 virtual bool Init(const base::Closure& callback) = 0;
30 35
31 // Returns true if |cert| is allowed to be used as a client certificate 36 // Returns true if |cert| is allowed to be used as a client certificate
32 // (e.g. for a certain browser context or user). 37 // (e.g. for a certain browser context or user).
33 // This is only called once initialization is finished, see Init(). 38 // This is only called once initialization is finished, see Init().
34 virtual bool IsCertAllowed( 39 virtual bool IsCertAllowed(
35 const scoped_refptr<net::X509Certificate>& cert) const = 0; 40 const scoped_refptr<net::X509Certificate>& cert) const = 0;
36 }; 41 };
37 42
38 // This ClientCertStore will return only client certs that pass the filter 43 // This ClientCertStore will return client certs from NSS certificate
39 // |cert_filter|. 44 // databases that pass the filter |cert_filter| and additionally return
45 // certificates provided by |cert_provider|.
40 ClientCertStoreChromeOS( 46 ClientCertStoreChromeOS(
47 scoped_ptr<CertificateProvider> cert_provider,
41 scoped_ptr<CertFilter> cert_filter, 48 scoped_ptr<CertFilter> cert_filter,
42 const PasswordDelegateFactory& password_delegate_factory); 49 const PasswordDelegateFactory& password_delegate_factory);
43 ~ClientCertStoreChromeOS() override; 50 ~ClientCertStoreChromeOS() override;
44 51
45 // net::ClientCertStoreNSS: 52 // net::ClientCertStore:
46 void GetClientCerts(const net::SSLCertRequestInfo& cert_request_info, 53 void GetClientCerts(const net::SSLCertRequestInfo& cert_request_info,
47 net::CertificateList* selected_certs, 54 net::CertificateList* selected_certs,
48 const base::Closure& callback) override; 55 const base::Closure& callback) override;
49 56
50 protected: 57 private:
51 // net::ClientCertStoreNSS: 58 void GotAdditionalCerts(const net::SSLCertRequestInfo* request,
52 void GetClientCertsImpl(CERTCertList* cert_list, 59 net::CertificateList* selected_certs,
53 const net::SSLCertRequestInfo& request, 60 const base::Closure& callback,
54 bool query_nssdb, 61 const net::CertificateList& additional_certs);
55 net::CertificateList* selected_certs) override;
56 62
57 private: 63 void GetAndFilterCertsOnWorkerThread(
58 void CertFilterInitialized(const net::SSLCertRequestInfo* request, 64 scoped_ptr<crypto::CryptoModuleBlockingPasswordDelegate>
59 net::CertificateList* selected_certs, 65 password_delegate,
60 const base::Closure& callback); 66 const net::SSLCertRequestInfo* request,
67 const net::CertificateList& additional_certs,
68 net::CertificateList* selected_certs);
61 69
70 scoped_ptr<CertificateProvider> cert_provider_;
62 scoped_ptr<CertFilter> cert_filter_; 71 scoped_ptr<CertFilter> cert_filter_;
63 72
73 // The factory for creating the delegate for requesting a password to a
74 // PKCS#11 token. May be null.
75 PasswordDelegateFactory password_delegate_factory_;
76
64 DISALLOW_COPY_AND_ASSIGN(ClientCertStoreChromeOS); 77 DISALLOW_COPY_AND_ASSIGN(ClientCertStoreChromeOS);
65 }; 78 };
66 79
67 } // namespace chromeos 80 } // namespace chromeos
68 81
69 #endif // CHROME_BROWSER_CHROMEOS_NET_CLIENT_CERT_STORE_CHROMEOS_H_ 82 #endif // CHROME_BROWSER_CHROMEOS_NET_CLIENT_CERT_STORE_CHROMEOS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698