Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 1274083002: Add flag to show toolkit-views dialogs on Mac, start with HTTP-Auth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Meatier comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index 05f4e37991ba9e52fa5c6e9b1bd1d102e5682be0..dc31fba59d26a2e1a1c28dbb6de2b15df47cb669 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -10,6 +10,7 @@
#include "ui/gfx/native_widget_types.h"
class Browser;
+class LoginHandler;
class Profile;
class SkBitmap;
@@ -23,6 +24,11 @@ namespace extensions {
class Extension;
}
+namespace net {
+class AuthChallengeInfo;
+class URLRequest;
+}
+
namespace ui {
class WebDialogDelegate;
}
@@ -69,6 +75,18 @@ void ShowCreateChromeAppShortcutsDialog(
content::ColorChooser* ShowColorChooser(content::WebContents* web_contents,
SkColor initial_color);
+#if defined(OS_MACOSX)
+
+// For Mac, returns true if Chrome should show an equivalent toolkit-views based
+// dialog using one of the functions below, rather than showing a Cocoa dialog.
+bool ToolkitViewsDialogsEnabled();
+
+#endif
+
+// Creates a toolkit-views based LoginHandler (e.g. HTTP-Auth dialog).
msw 2015/08/07 02:23:33 Hmm, should this be in a TOOLKIT_VIEWS ifdef? Mayb
tapted 2015/08/07 03:40:17 Done. (It's in non_ios_sources, but there at least
+LoginHandler* CreateLoginHandlerViews(net::AuthChallengeInfo* auth_info,
+ net::URLRequest* request);
+
} // namespace chrome
#endif // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_

Powered by Google App Engine
This is Rietveld 408576698