Add flag to show toolkit-views dialogs on Mac, start with HTTP-Auth.

chrome/browser/ui/cocoa/login_prompt_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/login_prompt_cocoa.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/tab_contents/tab_util.h"
+#include "chrome/browser/ui/browser_dialogs.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h"
 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
 #include "chrome/browser/ui/login/login_prompt.h"
 #include "components/password_manager/core/browser/login_model.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents.h"
 #include "net/url_request/url_request.h"
 #include "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"
 
@@ skipping 95 matching lines @@
   base::scoped_nsobject<LoginHandlerSheet> sheet_controller_;
 
   scoped_ptr<ConstrainedWindowMac> constrained_window_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginHandlerMac);
 };
 
 // static
 LoginHandler* LoginHandler::Create(net::AuthChallengeInfo* auth_info,
                                    net::URLRequest* request) {
+  if (chrome::ToolkitViewsDialogsEnabled())
+    return chrome::CreateLoginHandlerViews(auth_info, request);

[msw, 2015/08/07 02:23:33]

It'd be simpler if this could just "return new LoginHandlerViews(auth_info,
request);", but I'm guessing we don't allow direct dependencies on c/b/ui/views
within c/b/ui/cocoa, right?

[tapted, 2015/08/07 03:40:17]

Yeah exactly. - c/b/ui/cocoa inherits the views DEPS exclusion from c/b/ui/ and
I think it's nice to keep that to encourage good separation. (there's also the
problem that LoginHandlerViews is declared in the .cc file, so it would be more
disruptive to move out). (also the fallback file -- although it's in ui/views so
not affected by DEPS -- is kept a bit neater since it's not including headers
for an assortment of different dialogs).

   return new LoginHandlerMac(auth_info, request);
 }
 
 // ----------------------------------------------------------------------------
 // LoginHandlerSheet
 
 @implementation LoginHandlerSheet
 
 - (id)initWithLoginHandler:(LoginHandlerMac*)handler {
   NSString* nibPath =
@@ skipping 41 matching lines @@
   // Resize the text field.
   CGFloat windowDelta = [GTMUILocalizerAndLayoutTweaker
        sizeToFitFixedWidthTextField:explanationField_];
 
   NSRect newFrame = [[self window] frame];
   newFrame.size.height += windowDelta;
   [[self window] setFrame:newFrame display:NO];
 }
 
 @end