Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Side by Side Diff: pkg/compiler/lib/src/warnings.dart

Issue 1274073003: Refactor visitSendSet for super compounds and assignment. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Use bug number for TODOs Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/types/type_mask.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * The messages in this file should meet the following guide lines: 7 * The messages in this file should meet the following guide lines:
8 * 8 *
9 * 1. The message should be a complete sentence starting with an uppercase 9 * 1. The message should be a complete sentence starting with an uppercase
10 * letter, and ending with a period. 10 * letter, and ending with a period.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 ABSTRACT_METHOD, 75 ABSTRACT_METHOD,
76 ABSTRACT_SETTER, 76 ABSTRACT_SETTER,
77 ACCESSED_IN_CLOSURE, 77 ACCESSED_IN_CLOSURE,
78 ACCESSED_IN_CLOSURE_HERE, 78 ACCESSED_IN_CLOSURE_HERE,
79 ADDITIONAL_ARGUMENT, 79 ADDITIONAL_ARGUMENT,
80 ADDITIONAL_TYPE_ARGUMENT, 80 ADDITIONAL_TYPE_ARGUMENT,
81 ALREADY_INITIALIZED, 81 ALREADY_INITIALIZED,
82 AMBIGUOUS_LOCATION, 82 AMBIGUOUS_LOCATION,
83 AMBIGUOUS_REEXPORT, 83 AMBIGUOUS_REEXPORT,
84 ASSERT_IS_GIVEN_NAMED_ARGUMENTS, 84 ASSERT_IS_GIVEN_NAMED_ARGUMENTS,
85 ASSIGNING_FINAL_FIELD_IN_SUPER,
85 ASSIGNING_METHOD, 86 ASSIGNING_METHOD,
86 ASSIGNING_METHOD_IN_SUPER, 87 ASSIGNING_METHOD_IN_SUPER,
87 ASSIGNING_TYPE, 88 ASSIGNING_TYPE,
88 ASYNC_KEYWORD_AS_IDENTIFIER, 89 ASYNC_KEYWORD_AS_IDENTIFIER,
89 ASYNC_MODIFIER_ON_ABSTRACT_METHOD, 90 ASYNC_MODIFIER_ON_ABSTRACT_METHOD,
90 ASYNC_MODIFIER_ON_CONSTRUCTOR, 91 ASYNC_MODIFIER_ON_CONSTRUCTOR,
91 ASYNC_MODIFIER_ON_SETTER, 92 ASYNC_MODIFIER_ON_SETTER,
92 AWAIT_MEMBER_NOT_FOUND, 93 AWAIT_MEMBER_NOT_FOUND,
93 AWAIT_MEMBER_NOT_FOUND_IN_CLOSURE, 94 AWAIT_MEMBER_NOT_FOUND_IN_CLOSURE,
94 BAD_INPUT_CHARACTER, 95 BAD_INPUT_CHARACTER,
(...skipping 1661 matching lines...) Expand 10 before | Expand all | Expand 10 after
1756 "parameter name expected."), 1757 "parameter name expected."),
1757 1758
1758 MessageKind.CANNOT_RESOLVE_GETTER: 1759 MessageKind.CANNOT_RESOLVE_GETTER:
1759 const MessageTemplate(MessageKind.CANNOT_RESOLVE_GETTER, 1760 const MessageTemplate(MessageKind.CANNOT_RESOLVE_GETTER,
1760 "Cannot resolve getter."), 1761 "Cannot resolve getter."),
1761 1762
1762 MessageKind.CANNOT_RESOLVE_SETTER: 1763 MessageKind.CANNOT_RESOLVE_SETTER:
1763 const MessageTemplate(MessageKind.CANNOT_RESOLVE_SETTER, 1764 const MessageTemplate(MessageKind.CANNOT_RESOLVE_SETTER,
1764 "Cannot resolve setter."), 1765 "Cannot resolve setter."),
1765 1766
1767 MessageKind.ASSIGNING_FINAL_FIELD_IN_SUPER:
1768 const MessageTemplate(MessageKind.ASSIGNING_FINAL_FIELD_IN_SUPER,
1769 "Cannot assign a value to final field '#{name}' "
1770 "in superclass '#{superclassName}'."),
1771
1766 MessageKind.ASSIGNING_METHOD: 1772 MessageKind.ASSIGNING_METHOD:
1767 const MessageTemplate(MessageKind.ASSIGNING_METHOD, 1773 const MessageTemplate(MessageKind.ASSIGNING_METHOD,
1768 "Cannot assign a value to a method."), 1774 "Cannot assign a value to a method."),
1769 1775
1770 MessageKind.ASSIGNING_METHOD_IN_SUPER: 1776 MessageKind.ASSIGNING_METHOD_IN_SUPER:
1771 const MessageTemplate(MessageKind.ASSIGNING_METHOD_IN_SUPER, 1777 const MessageTemplate(MessageKind.ASSIGNING_METHOD_IN_SUPER,
1772 "Cannot assign a value to method '#{name}' " 1778 "Cannot assign a value to method '#{name}' "
1773 "in superclass '#{superclassName}'."), 1779 "in superclass '#{superclassName}'."),
1774 1780
1775 MessageKind.ASSIGNING_TYPE: 1781 MessageKind.ASSIGNING_TYPE:
(...skipping 1561 matching lines...) Expand 10 before | Expand all | Expand 10 after
3337 static String convertToString(value) { 3343 static String convertToString(value) {
3338 if (value is ErrorToken) { 3344 if (value is ErrorToken) {
3339 // Shouldn't happen. 3345 // Shouldn't happen.
3340 return value.assertionMessage; 3346 return value.assertionMessage;
3341 } else if (value is Token) { 3347 } else if (value is Token) {
3342 value = value.value; 3348 value = value.value;
3343 } 3349 }
3344 return '$value'; 3350 return '$value';
3345 } 3351 }
3346 } 3352 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/types/type_mask.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698