Refactor visitSendSet for super compounds and assignment.

tests/compiler/dart2js/resolver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:async_helper/async_helper.dart';
 import 'package:expect/expect.dart';
 import 'package:compiler/src/constants/expressions.dart';
@@ skipping 1237 matching lines @@
   checkWarningOn('''
       main() { new B().bar(); }
       class A {
         mname() {}
       }
       class B extends A {
         bar() {
           super.mname = () => 6;
         }
       }
-      ''', [MessageKind.ASSIGNING_METHOD_IN_SUPER]);
+      ''', [MessageKind.ASSIGNING_METHOD_IN_SUPER,
+            // TODO(johnniwinther): Avoid duplicate warnings.
+            MessageKind.SETTER_NOT_FOUND]);
 
   // But index operators should be OK
   checkWarningOn('''
       main() { new B().bar(); }
       class B {
         operator[]=(x, y) {}
         bar() {
           this[1] = 3; // This is OK
         }
       }
@@ skipping 55 matching lines @@
 
   // ... and in super class:
   checkWarningOn('''
       main() => new B().m();
       class A {
         final x = 1;
       }
       class B extends A {
         m() { super.x = 2; }
       }
-      ''', [MessageKind.SETTER_NOT_FOUND_IN_SUPER]);
+      ''', [MessageKind.ASSIGNING_FINAL_FIELD_IN_SUPER,
+            // TODO(johnniwinther): Avoid duplicate warnings.
+            MessageKind.SETTER_NOT_FOUND]);
 
   // But non-final fields are OK:
   checkWarningOn('''
       main() => new B().m();
       class A {
         int x = 1;
       }
       class B extends A {
         m() { super.x = 2; }
       }
       ''', []);
+
+  // Check getter without setter.
+  checkWarningOn('''
+      main() => new B().m();
+      class A {
+        get x => 1;
+      }
+      class B extends A {
+        m() { super.x = 2; }
+      }
+      ''', [MessageKind.SETTER_NOT_FOUND_IN_SUPER,
+            // TODO(johnniwinther): Avoid duplicate warnings.
+            MessageKind.SETTER_NOT_FOUND]);
 }
 
 /// Helper to test that [script] produces all the given [warnings].
 checkWarningOn(String script, List<MessageKind> warnings) {
   Expect.isTrue(warnings.length >= 0 && warnings.length <= 2);
   asyncTest(() => compileScript(script).then((compiler) {
-    Expect.equals(0, compiler.errors.length);
-    Expect.equals(warnings.length, compiler.warnings.length);
+    Expect.equals(0, compiler.errors.length,
+        'Unexpected errors in\n$script\n${compiler.errors}');
+    Expect.equals(warnings.length, compiler.warnings.length,
+        'Unexpected warnings in\n$script\n'
+        'Expected:$warnings\nFound:${compiler.warnings}');
     for (int i = 0; i < warnings.length; i++) {
       Expect.equals(warnings[i], compiler.warnings[i].message.kind);
     }
   }));
 }
 
 testAwaitHint() {
   check(String script, {String className, String functionName}) {
     var prefix = className == null
         ? "Cannot resolve 'await'"
@@ skipping 23 matching lines @@
     }
     main() => A.m();
   ''', functionName: 'm');
   check('''
     class A {
       m() => () => await - 3;
     }
     main() => new A().m();
   ''', className: 'A');
 }