third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 1274063003: [Loader] Make ThreadableLoader non-RefCounted and be managed by OwnPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 1274063003: [Loader] Make ThreadableLoader non-RefCounted and be managed by OwnPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reflect comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h ('K') | « third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp ('k') | third_party/WebKit/Source/web/AssociatedURLLoader.h » ('j') | third_party/WebKit/Source/web/AssociatedURLLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index 735755a1ab4ee2dc6af0b949d8fc9fb3adefc1a6..342bf97c6e0b43c9eeb689893c2db2aeb01f3866 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -39,6 +39,7 @@

#include "platform/weborigin/SecurityPolicy.h"

#include "public/platform/WebURLRequest.h"

#include "wtf/HashSet.h"

+#include "wtf/OwnPtr.h"

#include "wtf/Vector.h"

#include "wtf/text/WTFString.h"

@@ -167,7 +168,7 @@ private:

Member<FetchManager> m_fetchManager;

Member<ScriptPromiseResolver> m_resolver;

Member<FetchRequestData> m_request;

- RefPtr<ThreadableLoader> m_loader;

+ OwnPtr<ThreadableLoader> m_loader;

bool m_failed;

bool m_finished;

int m_responseHttpStatusCode;