Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp

Issue 1274063003: [Loader] Make ThreadableLoader non-RefCounted and be managed by OwnPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reflect comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
index 156ebe31d5d71f679f6558ab08295f135f87d265..66347b39f39c2e49757000052dd61abec0ddfe30 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
@@ -13,6 +13,7 @@
#include "platform/blob/BlobRegistry.h"
#include "platform/blob/BlobURL.h"
#include "platform/network/ResourceRequest.h"
+#include "wtf/OwnPtr.h"
namespace blink {
@@ -101,7 +102,7 @@ public:
}
private:
- PassRefPtr<ThreadableLoader> createLoader(ExecutionContext* executionContext, ThreadableLoaderClient* client) const
+ PassOwnPtr<ThreadableLoader> createLoader(ExecutionContext* executionContext, ThreadableLoaderClient* client) const
{
ThreadableLoaderOptions options;
options.preflightPolicy = ConsiderPreflight;
@@ -152,14 +153,14 @@ private:
RefPtr<BlobDataHandle> m_blobDataHandle;
Persistent<FetchBlobDataConsumerHandle::LoaderFactory> m_loaderFactory;
- RefPtr<ThreadableLoader> m_loader;
+ OwnPtr<ThreadableLoader> m_loader;
bool m_receivedResponse;
};
class DefaultLoaderFactory final : public FetchBlobDataConsumerHandle::LoaderFactory {
public:
- PassRefPtr<ThreadableLoader> create(
+ PassOwnPtr<ThreadableLoader> create(
ExecutionContext& executionContext,
ThreadableLoaderClient* client,
const ThreadableLoaderOptions& options,

Powered by Google App Engine
This is Rietveld 408576698