third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp - Issue 1274063003: [Loader] Make ThreadableLoader non-RefCounted and be managed by OwnPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

Issue 1274063003: [Loader] Make ThreadableLoader non-RefCounted and be managed by OwnPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp ('K') | « third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('j') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

index b1e595a753f3f561e2179551cd34f6d5d53210ee..d2d0a3a48424f2f532a427ddfa820b506d756b99 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

@@ -52,11 +52,11 @@ public:

explicit LoaderFactory(PassOwnPtr<WebDataConsumerHandle> handle)

: m_client(nullptr)

, m_handle(handle) {}

- PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient* client, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override

+ PassOwnPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient* client, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override

{

m_client = client;

- RefPtr<MockThreadableLoader> loader = MockThreadableLoader::create();

+ OwnPtr<MockThreadableLoader> loader = MockThreadableLoader::create();

EXPECT_CALL(*loader, start(_)).WillOnce(InvokeWithoutArgs(this, &LoaderFactory::handleDidReceiveResponse));

EXPECT_CALL(*loader, cancel()).Times(1);

return loader.release();