Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1274043004: Linux: Depend on liberation-fonts package. (try 2) (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Michael Moss
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Depend on liberation-fonts package. (try 2) Without these fonts, text in the built-in PDF viewer may not display correctly. Unfortunately we can only do this for the .deb packages at the moment. There's no common liberation-fonts package for RPMs. See https://crbug.com/519322. BUG=369991 Committed: https://crrev.com/d98c44a7c597056bcb14b7ff1e73dc5e2589482f Cr-Commit-Position: refs/heads/master@{#342854}

Patch Set 1 : Previous attempt #

Patch Set 2 : Add a note regarding RPMs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/installer/linux/debian/build.sh View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/rpm/build.sh View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 4 months ago (2015-08-11 18:36:01 UTC) #2
Michael Moss
lgtm
5 years, 4 months ago (2015-08-11 18:42:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274043004/20001
5 years, 4 months ago (2015-08-11 18:45:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 18:50:18 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 18:50:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d98c44a7c597056bcb14b7ff1e73dc5e2589482f
Cr-Commit-Position: refs/heads/master@{#342854}

Powered by Google App Engine
This is Rietveld 408576698