Vibration API: convert implementation to java mojo-service.

Vibration API: convert implementation to java mojo-service.

Implement mojo interface VibrationManager on Android
using Java directly instead of using C++ plus JNI.

BUG=439434
TEST=manually test vibration OK

Committed: https://crrev.com/25ac4910eef26d71cc94ee554626f6cad3f43e33
Cr-Commit-Position: refs/heads/master@{#343352}

[leonhsl(Using Gerrit), 2015-08-06 02:44:39]

leon.han@intel.com changed reviewers:
+ timvolodine@chromium.org

[leonhsl(Using Gerrit), 2015-08-06 02:44:40]

Hi, PTAL, Thanks.

[timvolodine, 2015-08-07 13:42:31]

thanks leon.han@! comments below. could you please run the trybots as well?

https://codereview.chromium.org/1274033002/diff/1/device/vibration/BUILD.gn
File device/vibration/BUILD.gn (right):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/BUILD.gn#n...
device/vibration/BUILD.gn:14: "vibration_manager_impl_default.cc",
we probably still want to exclude this for android

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/BU...
File device/vibration/android/BUILD.gn (right):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/BU...
device/vibration/android/BUILD.gn:8:
android_library("vibration_manager_android") {
could you please tweak the --similarity when uploading to not have the left diff
(this should show as new file in rietveld)

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/ja...
File
device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
(right):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/ja...
device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:42:
public void onConnectionError(MojoException e) {}
is it necessary to override this method if it's empty anyway?

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/ja...
device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:45:
public void vibrate(long milliseconds) {
what about the sanity check in vibration_manager_impl_android.cc?
(https://code.google.com/p/chromium/codesearch#chromium/src/device/vibration/v...)

https://codereview.chromium.org/1274033002/diff/1/device/vibration/vibration.gyp
File device/vibration/vibration.gyp (left):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/vibration....
device/vibration/vibration.gyp:51: 'vibration_manager_impl_default.cc',
same here: exclude on android?

[leonhsl(Using Gerrit), 2015-08-10 03:27:30]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-10 03:27:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274033002/1

[commit-bot: I haz the power, 2015-08-10 03:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-10 03:27:36]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[leonhsl(Using Gerrit), 2015-08-10 05:38:32]

Patchset #4 (id:60001) has been deleted

[leonhsl(Using Gerrit), 2015-08-10 05:39:11]

Patchset #3 (id:40001) has been deleted

[leonhsl(Using Gerrit), 2015-08-10 05:52:54]

Hi, Tim, 
Thanks a lot for review! Addressed the comments.
As this issue has not gotten LGTM and I'm not a project committer, I can't start
the trybot Dry run. Would you please help to start it? Thanks~

https://codereview.chromium.org/1274033002/diff/1/device/vibration/BUILD.gn
File device/vibration/BUILD.gn (right):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/BUILD.gn#n...
device/vibration/BUILD.gn:14: "vibration_manager_impl_default.cc",
On 2015/08/07 13:42:31, timvolodine wrote:
> we probably still want to exclude this for android

Done.

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/BU...
File device/vibration/android/BUILD.gn (right):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/BU...
device/vibration/android/BUILD.gn:8:
android_library("vibration_manager_android") {
On 2015/08/07 13:42:31, timvolodine wrote:
> could you please tweak the --similarity when uploading to not have the left
diff
> (this should show as new file in rietveld)

Done.

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/ja...
File
device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
(right):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/ja...
device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:42:
public void onConnectionError(MojoException e) {}
On 2015/08/07 13:42:31, timvolodine wrote:
> is it necessary to override this method if it's empty anyway?

It's an abstract method of interface ConnectionErrorHandler and I confirmed that
no override will raise compile error.

https://codereview.chromium.org/1274033002/diff/1/device/vibration/android/ja...
device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:45:
public void vibrate(long milliseconds) {
On 2015/08/07 13:42:31, timvolodine wrote:
> what about the sanity check in vibration_manager_impl_android.cc?
>
(https://code.google.com/p/chromium/codesearch#chromium/src/device/vibration/v...)

Done.

https://codereview.chromium.org/1274033002/diff/1/device/vibration/vibration.gyp
File device/vibration/vibration.gyp (left):

https://codereview.chromium.org/1274033002/diff/1/device/vibration/vibration....
device/vibration/vibration.gyp:51: 'vibration_manager_impl_default.cc',
On 2015/08/07 13:42:31, timvolodine wrote:
> same here: exclude on android?

Done.

[leonhsl(Using Gerrit), 2015-08-12 04:38:55]

Fixed the trybot failures. 
Sorry still need help to run trybot to verify. Thanks~

Also, If you think it's make sense I would prepare a CL to exclude the building
of the C++ BatteryMonitor implementation file from Android build.

[timvolodine, 2015-08-12 15:39:02]

On 2015/08/12 04:38:55, leon.han wrote:
> Fixed the trybot failures. 
> Sorry still need help to run trybot to verify. Thanks~
> 
> Also, If you think it's make sense I would prepare a CL to exclude the
building
> of the C++ BatteryMonitor implementation file from Android build.

ok thanks, I've kicked off try bots again let's see what it gives. Other than
that looks ok to me.

[timvolodine, 2015-08-12 18:25:32]

the bots look green now, I assume you have tested this on android? if so, lgtm.

it appears we don't have a browsertest for vibration, that's something to
potentially look at as well in the future.

[leonhsl(Using Gerrit), 2015-08-13 02:38:21]

On 2015/08/12 18:25:32, timvolodine wrote:
> the bots look green now, I assume you have tested this on android? if so,
lgtm.
> 
> it appears we don't have a browsertest for vibration, that's something to
> potentially look at as well in the future.

Yes I've tested on android devices.
And I'd like to continue to try to create the vibration browsertest,
once the CL prepared I'll add you as reviewer. Thanks~

[leonhsl(Using Gerrit), 2015-08-13 02:42:34]

leon.han@intel.com changed reviewers:
+ jam@chromium.org

[leonhsl(Using Gerrit), 2015-08-13 02:42:35]

Add jam@ for //content owner review. Thanks.

[jam, 2015-08-13 21:30:25]

lgtm

[leonhsl(Using Gerrit), 2015-08-14 04:46:27]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2015-08-14 04:46:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274033002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274033002/100001

[haltonhuo, 2015-08-14 04:46:47]

I'm on vacation, please expect slow email response.

[commit-bot: I haz the power, 2015-08-14 06:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-14 06:03:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[leonhsl(Using Gerrit), 2015-08-14 06:56:42]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2015-08-14 06:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274033002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274033002/100001

[commit-bot: I haz the power, 2015-08-14 07:55:00]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-08-14 07:55:48]

Patchset 4 (id:??) landed as
https://crrev.com/25ac4910eef26d71cc94ee554626f6cad3f43e33
Cr-Commit-Position: refs/heads/master@{#343352}