[Autofill, Sync] Sync additional Autofill address fields for i18n.

[Autofill, Sync] Sync additional Autofill address fields for i18n.

BUG=299154
TEST=unit_tests
R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243832

[Evan Stade, 2014-01-08 21:53:36]

lgtm

[Ilya Sherman, 2014-01-08 23:15:47]

Nicolas, could you please take a look at the Sync code?

[Nicolas Zea, 2014-01-08 23:54:38]

Mostly LG, but I'm slightly concerned about the upgrade scenario. On restart,
will the client immediately write these fields for for existing profiles?
Perhaps we should only write those fields if they're non-empty?

[Ilya Sherman, 2014-01-09 00:29:38]

On 2014/01/08 23:54:38, Nicolas Zea wrote:
> I'm slightly concerned about the upgrade scenario. On restart,
> will the client immediately write these fields for for existing profiles?
> Perhaps we should only write those fields if they're non-empty?

It would, except that it doesn't generate any Sync changes for profiles that are
identical on the client and on the server.  I actually wrote a test for this:
AutofillProfileSyncableServiceTest.MergeDataEmptyStreetAddress.  In that test,
all three of the new fields are unset in the Sync specifics, but no Sync changes
are generated.  Does that appease your concerns?

[Nicolas Zea, 2014-01-09 00:33:18]

Yep, that's exactly the right approach. LGTM

[commit-bot: I haz the power, 2014-01-09 00:42:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/127403002/90001

[commit-bot: I haz the power, 2014-01-09 10:27:35]

Change committed as 243832