Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274013003: Move GrDrawAtlasBatch to separate file (Closed)

Created:
5 years, 4 months ago by jvanverth1
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@drawAtlas-08-06
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Move to batches dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -164 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 3 chunks +4 lines, -164 lines 0 comments Download
A src/gpu/batches/GrDrawAtlasBatch.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
A src/gpu/batches/GrDrawAtlasBatch.cpp View 1 1 chunk +211 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jvanverth1
5 years, 4 months ago (2015-08-07 18:39:34 UTC) #2
joshualitt
On 2015/08/07 18:39:34, jvanverth1 wrote: lgtm
5 years, 4 months ago (2015-08-07 18:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274013003/1
5 years, 4 months ago (2015-08-07 18:40:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274013003/1
5 years, 4 months ago (2015-08-07 18:48:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa
5 years, 4 months ago (2015-08-07 18:49:20 UTC) #9
jvanverth1
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1276173003/ by jvanverth@google.com. ...
5 years, 4 months ago (2015-08-07 18:53:01 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274013003/20001
5 years, 4 months ago (2015-08-07 19:02:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274013003/20001
5 years, 4 months ago (2015-08-07 19:15:20 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 19:18:57 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/14b8803b7c49b736c756988fe1f5912da907b474

Powered by Google App Engine
This is Rietveld 408576698