Fix bmp RLE "bug" and add invalid image test to CodexTest

tests/CodexTest.cpp

Index: tests/CodexTest.cpp
diff --git a/tests/CodexTest.cpp b/tests/CodexTest.cpp
index b7f1584a16a29a52724c44e752fc7e9f56897d29..21b39816964ade1a810dcd0b4a4261c6fa1212fc 100644
--- a/tests/CodexTest.cpp
+++ b/tests/CodexTest.cpp
@@ -266,7 +266,7 @@ DEF_TEST(Codec_Dimensions, r) {
     test_dimensions(r, "randPixels.jpg");
 }
 
-static void test_empty(skiatest::Reporter* r, const char path[]) {
+static void test_invalid(skiatest::Reporter* r, const char path[]) {
     SkAutoTDelete<SkStream> stream(resource(path));
     if (!stream) {
         SkDebugf("Missing resource '%s'\n", path);
@@ -278,16 +278,18 @@ static void test_empty(skiatest::Reporter* r, const char path[]) {
 
 DEF_TEST(Codec_Empty, r) {
     // Test images that should not be able to create a codec
-    test_empty(r, "empty_images/zero-dims.gif");
-    test_empty(r, "empty_images/zero-embedded.ico");
-    test_empty(r, "empty_images/zero-width.bmp");
-    test_empty(r, "empty_images/zero-height.bmp");
-    test_empty(r, "empty_images/zero-width.jpg");
-    test_empty(r, "empty_images/zero-height.jpg");
-    test_empty(r, "empty_images/zero-width.png");
-    test_empty(r, "empty_images/zero-height.png");
-    test_empty(r, "empty_images/zero-width.wbmp");
-    test_empty(r, "empty_images/zero-height.wbmp");
+    test_invalid(r, "empty_images/zero-dims.gif");
+    test_invalid(r, "empty_images/zero-embedded.ico");
+    test_invalid(r, "empty_images/zero-width.bmp");
+    test_invalid(r, "empty_images/zero-height.bmp");
+    test_invalid(r, "empty_images/zero-width.jpg");
+    test_invalid(r, "empty_images/zero-height.jpg");
+    test_invalid(r, "empty_images/zero-width.png");
+    test_invalid(r, "empty_images/zero-height.png");
+    test_invalid(r, "empty_images/zero-width.wbmp");
+    test_invalid(r, "empty_images/zero-height.wbmp");
+    // This image is an ico with an embedded mask-bmp.  This is illegal.
+    test_invalid(r, "invalid_mask-bmp_ico.ico");

[scroggo, 2015/08/12 14:14:30]

Can you move this file into resources/invalid_images? That way we can run:

  dm --src image --images resources

and expect it to succeed.

I do not feel strongly about the name, but invalid will then be redundant.

[msarett, 2015/08/12 15:01:24]

Done.

 }
 
 static void test_invalid_parameters(skiatest::Reporter* r, const char path[]) {