Issue 1273843002: Rename component build variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1273843002: Rename component build variable. (Closed)

Created:
5 years, 4 months ago by brettw

Modified:
5 years, 4 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Rename component build variable. The Chromium build currently defines both is_component_build (boolean) and component_mode (a string). We're trying to standardize on the boolean. TBR=jshin Committed: https://chromium.googlesource.com/chromium/deps/icu/+/bbb24c53b4f46025e87a5973c39fa722c8757595

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (3 generated)

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

5 years, 4 months ago (2015-08-05 16:14:03 UTC) #5

brettw

5 years, 4 months ago (2015-08-05 16:14:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bbb24c53b4f46025e87a5973c39fa722c8757595 (presubmit successful).