Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: src/processor/minidump_processor.cc

Issue 1273823004: Add check for Linux minidump ending on bad write for exploitability rating. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/processor/minidump_processor.cc
===================================================================
--- src/processor/minidump_processor.cc (revision 1491)
+++ src/processor/minidump_processor.cc (working copy)
@@ -51,7 +51,8 @@
SourceLineResolverInterface *resolver)
: frame_symbolizer_(new StackFrameSymbolizer(supplier, resolver)),
own_frame_symbolizer_(true),
- enable_exploitability_(false) {
+ enable_exploitability_(false),
+ enable_objdump_(false) {
}
MinidumpProcessor::MinidumpProcessor(SymbolSupplier *supplier,
@@ -59,7 +60,8 @@
bool enable_exploitability)
: frame_symbolizer_(new StackFrameSymbolizer(supplier, resolver)),
own_frame_symbolizer_(true),
- enable_exploitability_(enable_exploitability) {
+ enable_exploitability_(enable_exploitability),
+ enable_objdump_(false) {
}
MinidumpProcessor::MinidumpProcessor(StackFrameSymbolizer *frame_symbolizer,
@@ -66,7 +68,8 @@
bool enable_exploitability)
: frame_symbolizer_(frame_symbolizer),
own_frame_symbolizer_(false),
- enable_exploitability_(enable_exploitability) {
+ enable_exploitability_(enable_exploitability),
+ enable_objdump_(false) {
assert(frame_symbolizer_);
}
@@ -289,7 +292,9 @@
// rating.
if (enable_exploitability_) {
scoped_ptr<Exploitability> exploitability(
- Exploitability::ExploitabilityForPlatform(dump, process_state));
+ Exploitability::ExploitabilityForPlatform(dump,
+ process_state,
+ enable_objdump_));
// The engine will be null if the platform is not supported
if (exploitability != NULL) {
process_state->exploitability_ = exploitability->CheckExploitability();
« no previous file with comments | « src/processor/exploitability_unittest.cc ('k') | src/processor/testdata/linux_jmp_to_module_not_exe_region.dmp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698