Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: src/google_breakpad/processor/exploitability.h

Issue 1273823004: Add check for Linux minidump ending on bad write for exploitability rating. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/google_breakpad/processor/minidump_processor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/google_breakpad/processor/exploitability.h
===================================================================
--- src/google_breakpad/processor/exploitability.h (revision 1491)
+++ src/google_breakpad/processor/exploitability.h (working copy)
@@ -53,6 +53,15 @@
static Exploitability *ExploitabilityForPlatform(Minidump *dump,
ProcessState *process_state);
+ // The boolean parameter signals whether the exploitability engine is
+ // enabled to call out to objdump for disassembly. This is disabled by
+ // default. It is used to check the identity of the instruction that
+ // caused the program to crash. This should not be enabled if there are
+ // portability concerns.
+ static Exploitability *ExploitabilityForPlatform(Minidump *dump,
+ ProcessState *process_state,
+ bool enable_objdump);
+
ExploitabilityRating CheckExploitability();
bool AddressIsAscii(uint64_t);
« no previous file with comments | « no previous file | src/google_breakpad/processor/minidump_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698