Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/processor/exploitability_linux.h

Issue 1273823004: Add check for Linux minidump ending on bad write for exploitability rating. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 Google Inc. 1 // Copyright (c) 2013 Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 virtual ExploitabilityRating CheckPlatformExploitability(); 51 virtual ExploitabilityRating CheckPlatformExploitability();
52 52
53 private: 53 private:
54 // This method takes the address of the instruction pointer and returns 54 // This method takes the address of the instruction pointer and returns
55 // whether the instruction pointer lies in a valid instruction region. 55 // whether the instruction pointer lies in a valid instruction region.
56 bool InstructionPointerInCode(uint64_t instruction_ptr); 56 bool InstructionPointerInCode(uint64_t instruction_ptr);
57 57
58 // This method checks the exception that triggered the creation of the 58 // This method checks the exception that triggered the creation of the
59 // minidump and reports whether the exception suggests no exploitability. 59 // minidump and reports whether the exception suggests no exploitability.
60 bool BenignCrashTrigger(const MDRawExceptionStream *raw_exception_stream); 60 bool BenignCrashTrigger(const MDRawExceptionStream *raw_exception_stream);
61
62 // This method checks if the crash occurred during a write to read-only
ahonig 2015/08/10 22:53:11 nit, read-only or completely invalid memory right?
liuandrew 2015/08/17 21:37:36 Done. Yes, both read-only and invalid.
63 // memory. It does so by checking if the instruction at the instruction
64 // pointer is a write instruction, and if the target of the instruction
65 // is at a spot in memory that prohibits writes.
66 bool EndedOnIllegalWrite(uint64_t instruction_ptr);
61 }; 67 };
62 68
63 } // namespace google_breakpad 69 } // namespace google_breakpad
64 70
65 #endif // GOOGLE_BREAKPAD_PROCESSOR_EXPLOITABILITY_LINUX_H_ 71 #endif // GOOGLE_BREAKPAD_PROCESSOR_EXPLOITABILITY_LINUX_H_
OLDNEW
« no previous file with comments | « no previous file | src/processor/exploitability_linux.cc » ('j') | src/processor/exploitability_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698