Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: src/google_breakpad/processor/minidump_processor.h

Issue 1273823004: Add check for Linux minidump ending on bad write for exploitability rating. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/google_breakpad/processor/exploitability.h ('k') | src/processor/exploitability.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006, Google Inc. 1 // Copyright (c) 2006, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 static bool IsErrorUnrecoverable(ProcessResult p) { 118 static bool IsErrorUnrecoverable(ProcessResult p) {
119 assert(p != PROCESS_OK); 119 assert(p != PROCESS_OK);
120 return (p != PROCESS_SYMBOL_SUPPLIER_INTERRUPTED); 120 return (p != PROCESS_SYMBOL_SUPPLIER_INTERRUPTED);
121 } 121 }
122 122
123 // Returns a textual representation of an assertion included 123 // Returns a textual representation of an assertion included
124 // in the minidump. Returns an empty string if this information 124 // in the minidump. Returns an empty string if this information
125 // does not exist or cannot be determined. 125 // does not exist or cannot be determined.
126 static string GetAssertion(Minidump* dump); 126 static string GetAssertion(Minidump* dump);
127 127
128 void set_enable_objdump(bool enabled) { enable_objdump_ = enabled; }
129
128 private: 130 private:
129 StackFrameSymbolizer* frame_symbolizer_; 131 StackFrameSymbolizer* frame_symbolizer_;
130 // Indicate whether resolver_helper_ is owned by this instance. 132 // Indicate whether resolver_helper_ is owned by this instance.
131 bool own_frame_symbolizer_; 133 bool own_frame_symbolizer_;
132 134
133 // This flag enables the exploitability scanner which attempts to 135 // This flag enables the exploitability scanner which attempts to
134 // guess how likely it is that the crash represents an exploitable 136 // guess how likely it is that the crash represents an exploitable
135 // memory corruption issue. 137 // memory corruption issue.
136 bool enable_exploitability_; 138 bool enable_exploitability_;
139
140 // This flag permits the exploitability scanner to shell out to objdump
141 // for purposes of disassembly.
142 bool enable_objdump_;
137 }; 143 };
138 144
139 } // namespace google_breakpad 145 } // namespace google_breakpad
140 146
141 #endif // GOOGLE_BREAKPAD_PROCESSOR_MINIDUMP_PROCESSOR_H__ 147 #endif // GOOGLE_BREAKPAD_PROCESSOR_MINIDUMP_PROCESSOR_H__
OLDNEW
« no previous file with comments | « src/google_breakpad/processor/exploitability.h ('k') | src/processor/exploitability.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698