Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1273813002: Add skstd::move and skstd::forward. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add skstd::move and skstd::forward. Since we can't use the c++11 standard library, re-implement the bits we want to use now. TBR=reed@google.com The next CL is try to move SkTemplates into private. Committed: https://skia.googlesource.com/skia/+/2bd028590d9db472e5b9ee44ca8961be5c036432

Patch Set 1 #

Patch Set 2 : Remove old SkMove, use real SkTForward. #

Patch Set 3 : No need to change the string. #

Total comments: 1

Patch Set 4 : skstd #

Patch Set 5 : Don't need to change animator anymore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M include/core/SkTemplates.h View 1 2 3 2 chunks +17 lines, -10 lines 0 comments Download
M include/private/SkFunction.h View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M include/private/SkTLogic.h View 1 2 3 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
bungeman-skia
I haven't actually used these yet, but I think these are the right implementations.
5 years, 4 months ago (2015-08-05 14:51:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273813002/20001
5 years, 4 months ago (2015-08-05 16:15:37 UTC) #4
bungeman-skia
Fixes. Take a look.
5 years, 4 months ago (2015-08-05 16:16:27 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-05 16:22:39 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273813002/40001
5 years, 4 months ago (2015-08-05 17:30:34 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-05 17:37:39 UTC) #11
bungeman-skia
I think we should land this, since it fixes our one existing 'forward' use. However, ...
5 years, 4 months ago (2015-08-05 17:43:11 UTC) #12
mtklein
lgtm, as do all bikesheds. I've noted one more bikeshed that'd be good enough for ...
5 years, 4 months ago (2015-08-05 17:48:01 UTC) #13
mtklein
On 2015/08/05 17:48:01, mtklein wrote: > lgtm, as do all bikesheds. I've noted one more ...
5 years, 4 months ago (2015-08-05 17:48:44 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273813002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273813002/80001
5 years, 4 months ago (2015-08-05 18:51:40 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-05 18:59:04 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273813002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273813002/80001
5 years, 4 months ago (2015-08-05 19:09:22 UTC) #23
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 19:10:00 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2bd028590d9db472e5b9ee44ca8961be5c036432

Powered by Google App Engine
This is Rietveld 408576698