Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1273803004: Use a factory function to create GrPipeline and remove unused member (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use a factory function to create GrPipeline and remove unused member Committed: https://skia.googlesource.com/skia/+/47dfc36e460356ef624ab90b82921ac6c8cc8e48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M src/gpu/GrDrawTarget.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/GrPipeline.h View 3 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 4 months ago (2015-08-10 15:14:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273803004/1
5 years, 4 months ago (2015-08-10 15:14:34 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-10 15:14:35 UTC) #5
egdaniel
lgtm
5 years, 4 months ago (2015-08-10 15:18:42 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 15:23:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/47dfc36e460356ef624ab90b82921ac6c8cc8e48

Powered by Google App Engine
This is Rietveld 408576698