Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1273803003: Make marquee-scroll a pixel test to avoid flakyness in render tree output. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
Reviewers:
Sami
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make marquee-scroll a pixel test to avoid flakyness in render tree output. BUG=432129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200252

Patch Set 1 #

Patch Set 2 : Add expected file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -126 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/html/marquee-scroll.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/marquee-scroll-expected.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/html/marquee-scroll-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/mac/fast/html/marquee-scroll-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/html/marquee-scroll-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/win/fast/html/marquee-scroll-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273803003/1
5 years, 4 months ago (2015-08-10 12:24:47 UTC) #2
rmcilroy
PTAL, thanks.
5 years, 4 months ago (2015-08-10 12:24:56 UTC) #4
Sami
Do we also need to add a NeedsRebaseline line to TestExpectations?
5 years, 4 months ago (2015-08-10 12:28:15 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273803003/20001
5 years, 4 months ago (2015-08-10 13:24:49 UTC) #8
rmcilroy
On 2015/08/10 12:28:15, Sami wrote: > Do we also need to add a NeedsRebaseline line ...
5 years, 4 months ago (2015-08-10 13:25:17 UTC) #9
Sami
On 2015/08/10 13:25:17, rmcilroy wrote: > On 2015/08/10 12:28:15, Sami wrote: > > Do we ...
5 years, 4 months ago (2015-08-10 13:34:01 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-10 14:37:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273803003/20001
5 years, 4 months ago (2015-08-10 17:09:39 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 17:12:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200252

Powered by Google App Engine
This is Rietveld 408576698