Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273793003: Fix make.py: BUILDTYPE (Closed)

Created:
5 years, 4 months ago by borenet
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix make.py: BUILDTYPE TBR=mtklein BUG=skia: NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/fa1c073b4c81e3ace8fa731d9358bfe4c2679e52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M make.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
borenet
I propose we wait to land this until we see some Windows Debug testers NOT ...
5 years, 4 months ago (2015-08-05 15:24:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273793003/1
5 years, 4 months ago (2015-08-05 15:28:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1628)
5 years, 4 months ago (2015-08-05 15:29:09 UTC) #8
borenet
5 years, 4 months ago (2015-08-05 15:30:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fa1c073b4c81e3ace8fa731d9358bfe4c2679e52.

Powered by Google App Engine
This is Rietveld 408576698