Issue 1273773002: Do not use the state as a parameter of the key in the url response cache.

Issue 1273773002: Do not use the state as a parameter of the key in the url response cache. (Closed)

Created:
5 years, 4 months ago by qsr

Modified:
5 years, 4 months ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Do not use the state as a parameter of the key in the url response cache. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4755323a17358ae88dff7dc82a53f6615f9e5c8f

Patch Set 2 : Follow review #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	services/url_response_disk_cache/url_response_disk_cache_impl.cc	View	1	2 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

lgtm % nit https://codereview.chromium.org/1273773002/diff/1/services/url_response_disk_cache/url_response_disk_cache_impl.cc File services/url_response_disk_cache/url_response_disk_cache_impl.cc (right): https://codereview.chromium.org/1273773002/diff/1/services/url_response_disk_cache/url_response_disk_cache_impl.cc#newcode71 services/url_response_disk_cache/url_response_disk_cache_impl.cc:71: std::string CanonicalizeURL(const std::string& url) { please ...

5 years, 4 months ago (2015-08-05 13:59:19 UTC) #2

qsr

Committed patchset #2 (id:20001) manually as 4755323a17358ae88dff7dc82a53f6615f9e5c8f (presubmit successful).

5 years, 4 months ago (2015-08-05 14:07:56 UTC) #3

qsr

5 years, 4 months ago (2015-08-05 14:07:57 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1273773002/diff/1/services/url_response_disk_...
File services/url_response_disk_cache/url_response_disk_cache_impl.cc (right):

https://codereview.chromium.org/1273773002/diff/1/services/url_response_disk_...
services/url_response_disk_cache/url_response_disk_cache_impl.cc:71: std::string
CanonicalizeURL(const std::string& url) {
On 2015/08/05 13:59:19, ppi wrote:
> please add a comment stating that we are matching the behavior of application
> manager, which connects to the same app if requested twice with different
query
> parameters.

Done.

Expand Messages | Collapse Messages