Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: mojo/dart/dart_snapshotter/logging.cc

Issue 1273743005: Dart: Adds a program to create snapshots of Mojo apps. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tonic/dart_error.h" 5 #include "mojo/dart/dart_snapshotter/logging.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace tonic {
10
11 namespace DartError {
12
13 const char kInvalidArgument[] = "Invalid argument.";
14
15 } // namespace DartError
16
17 bool LogIfError(Dart_Handle handle) { 9 bool LogIfError(Dart_Handle handle) {
18 if (Dart_IsError(handle)) { 10 if (Dart_IsError(handle)) {
19 LOG(ERROR) << Dart_GetError(handle); 11 LOG(ERROR) << Dart_GetError(handle);
20 12
21 // Only unhandled exceptions have stacktraces. 13 // Only unhandled exceptions have stacktraces.
22 if (!Dart_ErrorHasException(handle)) 14 if (!Dart_ErrorHasException(handle))
23 return true; 15 return true;
24 16
25 Dart_Handle stacktrace = Dart_ErrorGetStacktrace(handle); 17 Dart_Handle stacktrace = Dart_ErrorGetStacktrace(handle);
26 const char* stacktrace_cstr = ""; 18 const char* stacktrace_cstr = "";
27 Dart_StringToCString(Dart_ToString(stacktrace), &stacktrace_cstr); 19 Dart_StringToCString(Dart_ToString(stacktrace), &stacktrace_cstr);
28 LOG(ERROR) << stacktrace_cstr; 20 LOG(ERROR) << stacktrace_cstr;
29 return true; 21 return true;
30 } 22 }
31 return false; 23 return false;
32 } 24 }
33 25
34 } // namespace tonic 26 std::string StringFromDart(Dart_Handle string) {
27 CHECK(Dart_IsString(string));
28 uint8_t* utf8_array;
29 intptr_t length;
30 Dart_StringToUTF8(string, &utf8_array, &length);
31 return std::string(reinterpret_cast<const char*>(utf8_array), length);
32 }
33
34 Dart_Handle StringToDart(const std::string& string) {
35 return Dart_NewStringFromUTF8(reinterpret_cast<const uint8_t*>(string.data()),
36 string.length());
37 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698