Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1273743002: Add CompareSpdyHeaderBlocks() test helper method. (Closed)

Created:
5 years, 4 months ago by Bence
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CompareSpdyHeaderBlocks() test helper method. Add CompareSpdyHeaderBlocks() test helper method and use in tests instead of operator==(). This is in preparation for SpdyHeaderBlock becoming a LinkedHashMap which does not have operator== defined. No behavior change. This CL lands server change 99406076 by rjshade. BUG=443287 Committed: https://crrev.com/f29d63044b606b5e4236145e3e58ce709925eb21 Cr-Commit-Position: refs/heads/master@{#342201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M net/spdy/fuzzing/hpack_fuzz_util_test.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M net/spdy/hpack/hpack_decoder_test.cc View 9 chunks +9 lines, -12 lines 0 comments Download
M net/spdy/hpack/hpack_round_trip_test.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/spdy/spdy_test_utils.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/spdy/spdy_test_utils.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: veuillez jeter un coup d'œil s'il vous plaît. Merci beaucoup.
5 years, 4 months ago (2015-08-05 15:03:26 UTC) #2
Ryan Hamilton
lgtm
5 years, 4 months ago (2015-08-06 19:15:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273743002/1
5 years, 4 months ago (2015-08-06 19:50:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 21:34:13 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 21:34:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f29d63044b606b5e4236145e3e58ce709925eb21
Cr-Commit-Position: refs/heads/master@{#342201}

Powered by Google App Engine
This is Rietveld 408576698