Add cc:DrawQuad type for surfaces

Add cc:DrawQuad type for surfaces

This quad type just carries a surface ID to be resolved later. A quad of this type will always be replaced by the quads it represents (if any) before being passed to a cc:DirectRenderer for drawing.

BUG=334090
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245438

[jamesr, 2014-01-14 00:55:01]

For now a surface ID is just an int, so this doesn't need to refer to any
special types.

[danakj, 2014-01-14 18:31:57]

https://codereview.chromium.org/127373002/diff/50001/cc/quads/draw_quad.h
File cc/quads/draw_quad.h (right):

https://codereview.chromium.org/127373002/diff/50001/cc/quads/draw_quad.h#new...
cc/quads/draw_quad.h:40: SOLID_COLOR,
yay alphabeticalish

https://codereview.chromium.org/127373002/diff/50001/cc/quads/surface_draw_qu...
File cc/quads/surface_draw_quad.cc (right):

https://codereview.chromium.org/127373002/diff/50001/cc/quads/surface_draw_qu...
cc/quads/surface_draw_quad.cc:22: DrawQuad::SetAll(shared_quad_state,
DrawQuad::SURFACE_CONTENT, rect, rect,
Can you use temp vars to give these rects names, similar to
checkerboard_draw_quad.cc? Also, I think the opaque rect should be empty until
you have something visible in the quad in the future with some data to make that
decision on. (These won't be 100% opaque given you can have transparent
renderers.)

https://codereview.chromium.org/127373002/diff/50001/content/common/cc_messag...
File content/common/cc_messages_unittest.cc (right):

https://codereview.chromium.org/127373002/diff/50001/content/common/cc_messag...
content/common/cc_messages_unittest.cc:110:
Compare(SurfaceDrawQuad::MaterialCast(a),
This Compare method is not implemented yet.

https://codereview.chromium.org/127373002/diff/50001/content/common/cc_messag...
content/common/cc_messages_unittest.cc:369: 
add a surfacedrawquad into the frame here?

https://codereview.chromium.org/127373002/diff/50001/content/common/cc_messag...
content/common/cc_messages_unittest.cc:705: case cc::DrawQuad::TILED_CONTENT:
add the surface draw quad here

[enne (OOO), 2014-01-14 19:18:50]

lgtm % danakj

[jamesr, 2014-01-14 23:25:04]

Thanks!  I've added the cc_messages_unittest changes

jschuh@ - could you do an IPC review for content/common/cc_messages* ?  I'm
adding serialization here for surface quads, but in this patch they do nothing. 
Once I add some code to the browser that interprets these quads I'll
concurrently add an off-by-default command line flag to restrict interpretation
until the system's received a security review.  For now, the data isn't used so
there is no code to guard.

[danakj, 2014-01-14 23:34:06]

LGTM

[jamesr, 2014-01-16 20:51:37]

@jschuh - ping

[jschuh, 2014-01-16 21:35:55]

lgtm. sorry, apparently codesite ignored my lgtm yesterday.

[commit-bot: I haz the power, 2014-01-16 21:39:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/127373002/160001

[commit-bot: I haz the power, 2014-01-16 22:00:20]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[jamesr, 2014-01-16 22:39:56]

piman@ - could you review cc_messages.cc / cc_messages_unittest.cc please? 
jschuh's done an IPC review but his owners only applies to cc_messages.h

[commit-bot: I haz the power, 2014-01-16 22:41:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/127373002/160001

[piman, 2014-01-16 23:59:45]

lgtm

[commit-bot: I haz the power, 2014-01-17 00:03:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/127373002/160001

[commit-bot: I haz the power, 2014-01-17 06:32:38]

Change committed as 245438