Issue 12737010: Move call_with_timeout() guts into Proc.yield_any() generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12737010: Move call_with_timeout() guts into Proc.yield_any() generator. (Closed)

Created:
7 years, 9 months ago by M-A Ruel

Modified:
7 years, 9 months ago

Reviewers:
csharp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/swarm_client

Visibility:
Public.

More Reviews

Description

Move call_with_timeout() guts into Proc.yield_any() generator. This permits getting data on the fly and using a timeout. This will be used with progressive output parsing. Unit testing of call_with_timeout() applies to yield_any(). R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=189673

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -19 lines)			Patch
	M	run_test_cases.py	View	1	2 chunks	+26 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csharp

LGTM with nits https://codereview.chromium.org/12737010/diff/1/run_test_cases.py File run_test_cases.py (right): https://codereview.chromium.org/12737010/diff/1/run_test_cases.py#newcode207 run_test_cases.py:207: remaining = 0 nit: remaining -> ...

7 years, 9 months ago (2013-03-21 19:14:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12737010/5001

7 years, 9 months ago (2013-03-21 19:25:32 UTC) #3

Message was sent while issue was closed.

Change committed as 189673

Expand Messages | Collapse Messages