Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: chrome/browser/feedback/feedback_util.cc

Issue 12737006: Allow feedback form to be shown in an App Launcher feedback mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Next round Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/feedback_util.cc
diff --git a/chrome/browser/feedback/feedback_util.cc b/chrome/browser/feedback/feedback_util.cc
index 36615c57c86733eb9545b3e24d2b471da6254983..0b111b7a9d59a8aa334cfee9559ad9f035880661 100644
--- a/chrome/browser/feedback/feedback_util.cc
+++ b/chrome/browser/feedback/feedback_util.cc
@@ -46,12 +46,17 @@
using content::WebContents;
+namespace chrome {
+
const char kSyncDataKey[] = "about_sync_data";
+const char kAppLauncherCategoryTag[] = "AppLauncher";
#if defined(OS_CHROMEOS)
const char kHUDLogDataKey[] = "hud_log";
#endif
+} // namespace
+
namespace {
const int kFeedbackVersion = 1;
@@ -357,8 +362,8 @@ void FeedbackUtil::SendReport(const FeedbackData& data) {
// Add the product specific data
for (chromeos::system::LogDictionaryType::const_iterator i =
data.sys_info()->begin(); i != data.sys_info()->end(); ++i) {
- if (i->first == kSyncDataKey ||
- i->first == kHUDLogDataKey ||
+ if (i->first == chrome::kSyncDataKey ||
+ i->first == chrome::kHUDLogDataKey ||
ValidFeedbackSize(i->second)) {
AddFeedbackData(&feedback_data, i->first, i->second);
}

Powered by Google App Engine
This is Rietveld 408576698