Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/resources/feedback.html

Issue 12737006: Allow feedback form to be shown in an App Launcher feedback mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: First round of feedback Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback.html
diff --git a/chrome/browser/resources/feedback.html b/chrome/browser/resources/feedback.html
index ca55fc864ece17e6d326bd402eb16a009293bc6b..4956a3be0480aba203be6534f0035c857d94f652 100644
--- a/chrome/browser/resources/feedback.html
+++ b/chrome/browser/resources/feedback.html
@@ -14,9 +14,12 @@
</head>
<body id="feedback-page"
i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">
- <h1 i18n-content="title"></h1>
+ <h1 id="title" i18n-content="title"></h1>
+ <h1 id="launcher-title" i18n-content="launcher-title" hidden></h1>
Dan Beam 2013/03/15 15:29:51 this should probably be `i18n-content="launcherTit
rkc 2013/03/15 16:58:40 Since the rest of this file follows the word1-word
Dan Beam 2013/03/15 17:20:42 yes, it's fine to be locally consistent where it m
benwells 2013/03/18 05:21:19 OK, left as is for local consistency.
<div id="content">
<span id="description" colspan="2" i18n-content="description"></span>
+ <span id="launcher-description" colspan="2"
+ i18n-content="launcher-description" hidden></span>
Dan Beam 2013/03/15 15:29:51 and i18n-content="launcherDescription"
<textarea id="description-text" rows="10"></textarea>
<div id="page-url" class="input-text-container checkbox">
<label>

Powered by Google App Engine
This is Rietveld 408576698