Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 127363002: Provide fake audio parameters when devices don't exist. (Closed)

Created:
6 years, 11 months ago by DaleCurtis
Modified:
6 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Provide fake audio parameters when devices don't exist. These methods should always return valid parameters, even if a device doesn't exist. Output code will automatically fall back to a fake path at a later time if those parameters are used to open a stream. Input code will fail because no input devices can be enumerated. BUG=331675 TEST=no more crashes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M media/audio/mac/audio_manager_mac.cc View 3 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
6 years, 11 months ago (2014-01-08 01:27:59 UTC) #1
Raymond Toy (Google)
lgtm, but I'm not an owner. One small nit: would it be useful to have ...
6 years, 11 months ago (2014-01-08 20:51:14 UTC) #2
DaleCurtis
I'm an owner, which is sufficient w/ your approval. The key parts are already abstracted ...
6 years, 11 months ago (2014-01-08 21:12:31 UTC) #3
Raymond Toy (Google)
On 2014/01/08 21:12:31, DaleCurtis wrote: > I'm an owner, which is sufficient w/ your approval. ...
6 years, 11 months ago (2014-01-08 21:15:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/127363002/1
6 years, 11 months ago (2014-01-08 21:16:48 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 00:06:38 UTC) #6
Message was sent while issue was closed.
Change committed as 243704

Powered by Google App Engine
This is Rietveld 408576698