Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273543002: Delete --harmony-computed-property-names flag (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delete --harmony-computed-property-names flag It was shipped in V8 4.4. Committed: https://crrev.com/b7726c447a8528710f549ebeea21ff46ac90a43a Cr-Commit-Position: refs/heads/master@{#30038}

Patch Set 1 #

Patch Set 2 : Fix compile by adding block #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1139 lines) Patch
M src/bootstrapper.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M src/preparser.h View 1 2 4 chunks +10 lines, -15 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 12 chunks +9 lines, -29 lines 0 comments Download
M test/mjsunit/es6/block-const-assign.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/class-computed-property-names-super.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/computed-property-names.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/computed-property-names-classes.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/computed-property-names-deopt.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/computed-property-names-object-literals-methods.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/computed-property-names-super.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-const-assign-sloppy.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/harmony/class-computed-property-names-super.js View 1 chunk +0 lines, -76 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names.js View 1 chunk +0 lines, -302 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names-classes.js View 1 chunk +0 lines, -463 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names-deopt.js View 1 chunk +0 lines, -30 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names-object-literals-methods.js View 1 chunk +0 lines, -121 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names-super.js View 1 chunk +0 lines, -78 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring-parameters-literalcount.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring-parameters-literalcount-nolazy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-crbug-451770.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/declaration-after-use.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/strong/destructuring.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
5 years, 4 months ago (2015-08-04 22:53:29 UTC) #2
rossberg
lgtm
5 years, 4 months ago (2015-08-05 07:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273543002/40001
5 years, 4 months ago (2015-08-05 20:25:02 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-05 21:32:30 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 21:32:49 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b7726c447a8528710f549ebeea21ff46ac90a43a
Cr-Commit-Position: refs/heads/master@{#30038}

Powered by Google App Engine
This is Rietveld 408576698