Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 127353002: Clean-up: Move tabCapture API test data files out of experimental dir. (Closed)

Created:
6 years, 11 months ago by miu
Modified:
6 years, 11 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Clean-up: Move tabCapture API test data files out of experimental dir. The API has long been in stable, so the test files shouldn't be in an "experimental" directory hierarchy. Also, fixed minor issues caught by PRESUBMIT: 1) Removed tabs. 2) Corrected LOG(INFO) statements to more-appropriate LOG(ERROR). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -607 lines) Patch
chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 9 chunks +18 lines, -18 lines 0 comments Download
chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/active_tab_chrome_pages.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/active_tab_chrome_pages.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/api_tests.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/api_tests.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/api_tests_audio.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/api_tests_audio.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/constraints.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/constraints.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/end_to_end.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/end_to_end.js View 2 chunks +8 lines, -8 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/active_tab_chrome_pages.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/active_tab_chrome_pages.js View 1 chunk +0 lines, -14 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/active_tab_permission_test.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/active_tab_permission_test.js View 1 chunk +0 lines, -40 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/api_tests.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/api_tests.js View 1 chunk +0 lines, -88 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/api_tests_audio.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/api_tests_audio.js View 1 chunk +0 lines, -40 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/constraints.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/constraints.js View 1 chunk +0 lines, -40 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/end_to_end.html View 1 chunk +0 lines, -8 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/end_to_end.js View 1 chunk +0 lines, -160 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/fullscreen_test.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/fullscreen_test.js View 1 chunk +0 lines, -29 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/get_user_media_test.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/get_user_media_test.js View 1 chunk +0 lines, -23 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/incognito.html View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/incognito.js View 1 chunk +0 lines, -8 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/manifest.json View 1 chunk +0 lines, -9 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/performance.html View 1 chunk +0 lines, -7 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/experimental/performance.js View 1 chunk +0 lines, -118 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/fullscreen_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/fullscreen_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/get_user_media_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/get_user_media_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/incognito.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/incognito.js View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/performance.html View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/api_test/tab_capture/performance.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
miu
hclam: PTAL. Just moved files down a dir, and tweaked a few style issues (tab ...
6 years, 11 months ago (2014-01-08 01:23:34 UTC) #1
Alpha Left Google
lgtm
6 years, 11 months ago (2014-01-08 01:24:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/127353002/1
6 years, 11 months ago (2014-01-08 01:39:32 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 07:13:18 UTC) #4
Message was sent while issue was closed.
Change committed as 243510

Powered by Google App Engine
This is Rietveld 408576698