Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: src/heap/heap.h

Issue 1273483002: GC: Refactor public incremental marking interface in heap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add reason parameter to StartIncrementalMarking Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 750827968dcd757edff47ece2ed0948930aa688f..90fc2081f2f8dc8857f696273e44577813de9c71 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -852,6 +852,14 @@ class Heap {
// incremental steps.
void StartIdleIncrementalMarking();
+ void StartIncrementalMarking(int gc_flags,
Hannes Payer (out of office) 2015/08/04 15:05:59 Add comments to these functions.
Michael Lippautz 2015/08/04 15:53:06 Done.
+ const GCCallbackFlags gc_callback_flags,
+ const char* reason = nullptr);
+
+ double AdvanceIncrementalMarking(
+ intptr_t step_size_in_bytes, double deadline_in_ms,
+ IncrementalMarking::StepActions step_actions);
+
inline void increment_scan_on_scavenge_pages() {
scan_on_scavenge_pages_++;
if (FLAG_gc_verbose) {
@@ -2232,10 +2240,6 @@ class Heap {
GCIdleTimeHandler::HeapState ComputeHeapState();
- double AdvanceIncrementalMarking(
- intptr_t step_size_in_bytes, double deadline_in_ms,
- IncrementalMarking::ForceCompletionAction completion);
-
bool PerformIdleTimeAction(GCIdleTimeAction action,
GCIdleTimeHandler::HeapState heap_state,
double deadline_in_ms);
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698