Issue 1273433002: Revert of SkCanvas::onDrawPicture() quick-reject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1273433002: Revert of SkCanvas::onDrawPicture() quick-reject (Closed)

Created:
5 years, 4 months ago by mtklein

Modified:
5 years, 4 months ago

Reviewers:
f(malita), reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of SkCanvas::onDrawPicture() quick-reject (patchset #3 id:40001 of https://codereview.chromium.org/1264133003/ ) Reason for revert: webkit_unit_tests :( Original issue's description: > SkCanvas::onDrawPicture() quick-reject > > R=reed@google.com,mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/48ed62b29d45e42b971aac8858da06781c93e6d7 TBR=reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1d183b4cb31fd53547edad73b29ebec16e053d2a

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -13 lines)			Patch
	M	src/core/SkCanvas.cpp	View		1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273433002/1

5 years, 4 months ago (2015-08-04 01:08:28 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-04 01:08:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d183b4cb31fd53547edad73b29ebec16e053d2a

Expand Messages | Collapse Messages