Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

Issue 1273423004: Shows a launch spinner next to a sink once it is selected to create a route. The launch spinner sur… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
index eeae49cff8e46afeb8fa08ffde383aba29ead8c5..92f0b2fb6778755d281f256be8c4600ed51218b9 100644
--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
@@ -98,7 +98,7 @@ TEST_F(MediaRouterWebUIMessageHandlerTest, UpdateRoutes) {
EXPECT_EQ(is_local, actual_is_local);
}
-TEST_F(MediaRouterWebUIMessageHandlerTest, AddRoute) {
+TEST_F(MediaRouterWebUIMessageHandlerTest, OnCreateRouteResponseReceived) {
MediaRoute::Id route_id("routeId123");
MediaSink::Id sink_id("sinkId123");
MediaSink sink(sink_id, "The sink");
@@ -107,13 +107,19 @@ TEST_F(MediaRouterWebUIMessageHandlerTest, AddRoute) {
MediaRoute route(route_id, MediaSource("mediaSource"),
MediaSink(sink_id, "The sink"), description, is_local, "");
- handler_.AddRoute(route);
+ handler_.OnCreateRouteResponseReceived(sink_id, &route);
EXPECT_EQ(1u, web_ui_.call_data().size());
const content::TestWebUI::CallData& call_data = *web_ui_.call_data()[0];
- EXPECT_EQ("media_router.ui.addRoute", call_data.function_name());
+ EXPECT_EQ("media_router.ui.onCreateRouteResponseReceived",
+ call_data.function_name());
const base::Value* arg1 = call_data.arg1();
+ const base::StringValue* sink_id_value = nullptr;
+ EXPECT_TRUE(arg1->GetAsString(&sink_id_value));
+ EXPECT_EQ(sink_id, sink_id_value->GetString());
+
+ const base::Value* arg2 = call_data.arg2();
const base::DictionaryValue* route_value = nullptr;
- EXPECT_TRUE(arg1->GetAsDictionary(&route_value));
+ EXPECT_TRUE(arg2->GetAsDictionary(&route_value));
std::string value;
EXPECT_TRUE(route_value->GetString("id", &value));

Powered by Google App Engine
This is Rietveld 408576698