Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5150)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Issue 1273423004: Shows a launch spinner next to a sink once it is selected to create a route. The launch spinner sur… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move launch tracker to extension. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
index 2f7b84a3224005eaf666ddbd33b74df7f7714790..060ea5b5613d420a3fc066fb31d9d80130bc9847 100644
--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
@@ -23,6 +23,7 @@
id="cast-mode-header-text">[[selectCastModeHeaderText_]]</span>
</div>
<paper-icon-button icon="[[computeArrowDropIcon_(currentView_)]]"
+ disabled$="[[isLaunching_]]"
Kevin M 2015/08/11 21:28:47 Could you create a compute function for this value
haibinlu 2015/08/12 20:32:53 This variable is used at quite a few places. is it
id="arrow-drop-icon" on-click="toggleCastModeHidden_">
apacible 2015/08/11 18:29:58 nit: move id to previous line since it looks like
haibinlu 2015/08/12 20:32:53 Done.
</paper-icon-button>
<paper-icon-button icon="close" id="close-button"
@@ -35,9 +36,9 @@
<paper-menu id="cast-mode-list"
hidden$="[[computeCastModeHidden_(currentView_)]]">
<template is="dom-repeat" id="castModeList" items="[[castModeList]]">
- <paper-item class="cast-mode" on-click="onCastModeClick_">
+ <paper-item on-click="onCastModeClick_">
<!-- TODO(apacible): Show icon based on cast mode. -->
- <iron-icon icon="tab"></iron-icon>
+ <iron-icon icon="tab" class="cast-mode"></iron-icon>
<div>
<span>[[item.description]]</span>
</div>
@@ -68,9 +69,13 @@
<div class="sink-content">
<div>
<!-- TODO(apacible): Show device icon based on device type. -->
- <iron-icon icon="hardware:tv"
+ <iron-icon icon="hardware:tv" hidden$="[[item.isLaunching]]"
class$="[[computeSinkIconClass_(item.id, sinkToRouteMap_)]]">
</iron-icon>
+ <template is="dom-if" if="[[item.isLaunching]]">
+ <paper-spinner class="sink-icon" active>
+ </paper-spinner>
+ </template>
</div>
<div>
<div class="sink-text">

Powered by Google App Engine
This is Rietveld 408576698