Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2412)

Unified Diff: chrome/browser/resources/media_router/media_router_data.js

Issue 1273423004: Shows a launch spinner next to a sink once it is selected to create a route. The launch spinner sur… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Kevin's comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/media_router_data.js
diff --git a/chrome/browser/resources/media_router/media_router_data.js b/chrome/browser/resources/media_router/media_router_data.js
index a61897ff54312151899cdd83ef10b7a899dcbff9..aaa0c9707cce330885b8fac933921d66dda131e7 100644
--- a/chrome/browser/resources/media_router/media_router_data.js
+++ b/chrome/browser/resources/media_router/media_router_data.js
@@ -122,10 +122,12 @@ cr.define('media_router', function() {
* @param {string} name The name of the sink.
* @param {media_router.SinkStatus} status The readiness state of the sink.
* @param {!Array<number>} castModes Cast modes compatible with the sink.
+ * @param {boolean} isLaunching True if the Media Router is creating a route
+ * to this sink.
apacible 2015/08/10 14:13:27 nit: align with "isLaunching" on the line above.
haibinlu 2015/08/11 01:31:47 Done.
* @constructor
* @struct
*/
- var Sink = function(id, name, status, castModes) {
+ var Sink = function(id, name, status, castModes, isLaunching) {
/** @type {string} */
this.id = id;
@@ -137,6 +139,9 @@ cr.define('media_router', function() {
/** @type {!Array<number>} */
this.castModes = castModes;
+
+ /** @type {boolean} */
+ this.isLaunching = isLaunching;
};

Powered by Google App Engine
This is Rietveld 408576698