Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4426)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Issue 1273423004: Shows a launch spinner next to a sink once it is selected to create a route. The launch spinner sur… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
index 1fe5f7aa88e0e38e34ce943dec8e687b84006cc6..4a13156cd6884c0db435c16d85bd0f325b362151 100644
--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
@@ -24,7 +24,8 @@
id="cast-mode-header-text">[[selectCastModeHeaderText_]]</span>
</div>
<paper-icon-button icon="[[computeArrowDropIcon_(currentView_)]]"
- id="arrow-drop-icon" on-click="toggleCastModeHidden_">
+ disabled$="[[isLaunching_(sinkList)]]" id="arrow-drop-icon"
+ on-click="toggleCastModeHidden_">
</paper-icon-button>
<paper-icon-button icon="close" id="close-button"
on-click="onCloseButtonClick_">
@@ -37,8 +38,10 @@
hidden$="[[computeCastModeHidden_(currentView_)]]">
<template is="dom-repeat" id="defaultCastModeList"
items="[[computeDefaultCastModeList_(castModeList)]]">
- <paper-item class="cast-mode" on-click="onCastModeClick_">
- <iron-icon icon="[[computeCastModeIcon_(item)]]"></iron-icon>
+ <paper-item on-click="onCastModeClick_">
+ <iron-icon class="cast-mode-icon"
+ icon="[[computeCastModeIcon_(item)]]">
+ </iron-icon>
<div><span>[[item.host]]</span></div>
</paper-item>
</template>
@@ -48,8 +51,10 @@
</div>
<template is="dom-repeat" id="nonDefaultCastModeList"
items="[[computeNonDefaultCastModeList_(castModeList)]]">
- <paper-item class="cast-mode" on-click="onCastModeClick_">
- <iron-icon icon="[[computeCastModeIcon_(item)]]"></iron-icon>
+ <paper-item on-click="onCastModeClick_">
+ <iron-icon class="cast-mode-icon"
+ icon="[[computeCastModeIcon_(item)]]">
+ </iron-icon>
<div><span>[[item.description]]</span></div>
</paper-item>
</template>
@@ -78,9 +83,13 @@
<div class="sink-content">
<div>
<!-- TODO(apacible): Show device icon based on device type. -->
- <iron-icon icon="hardware:tv"
+ <iron-icon icon="hardware:tv" hidden$="[[item.isLaunching]]"
class$="[[computeSinkIconClass_(item.id, sinkToRouteMap_)]]">
</iron-icon>
+ <template is="dom-if" if="[[item.isLaunching]]">
+ <paper-spinner class="sink-icon" active>
+ </paper-spinner>
+ </template>
</div>
<div>
<div class="sink-text">

Powered by Google App Engine
This is Rietveld 408576698