Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1273363006: Rename BasicURLRequestContext. (Closed)

Created:
5 years, 4 months ago by wjmaclean
Modified:
5 years, 4 months ago
Reviewers:
garykac, mmenke, Jamie
CC:
chromium-reviews, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename BasicURLRequestContext. The name "BasicURLRequestContext" is misleading, as it is *more* than just a URLRequestContext. Instead, it's a URLRequestContext with added storage to contain owned-pointers to the context's components. This rename better reflects that distinction. BUG=none Committed: https://crrev.com/7f36a61b25654fdcbfd4e4fd6f7476b75908169e Cr-Commit-Position: refs/heads/master@{#342984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M net/url_request/url_request_context_builder.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M remoting/host/chromoting_host_context.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273363006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273363006/1
5 years, 4 months ago (2015-08-11 13:30:08 UTC) #2
wjmaclean
Minor rename ... garykac@chromium.org: Please review changes in remoting:: mmenke@chromium.org: Please review changes in net::
5 years, 4 months ago (2015-08-11 13:31:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-11 14:38:15 UTC) #6
mmenke
LGTM
5 years, 4 months ago (2015-08-11 15:18:08 UTC) #7
Jamie
remoting/ lgtm
5 years, 4 months ago (2015-08-11 16:34:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273363006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273363006/1
5 years, 4 months ago (2015-08-12 07:12:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 07:31:35 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 07:32:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f36a61b25654fdcbfd4e4fd6f7476b75908169e
Cr-Commit-Position: refs/heads/master@{#342984}

Powered by Google App Engine
This is Rietveld 408576698